On Thu, 20 Jun 2024 19:01:29 GMT, Justin Lu <j...@openjdk.org> wrote:
> > It's not about this update, but it may be better to rename the > > `tablea1.txt` data file to `list-one.txt` or something along the line. The > > name `tablea1` is obsolete, and it is now called "List one: Currency, fund > > and precious metal codes" > > https://www.six-group.com/en/products-services/financial-information/data-standards.html > > Without further context, it is hard to infer meaning from `tablea1.txt` or > `list-one.txt`. I have renamed it to `ISO4217-codes.txt`, which I think is > much more straight forward and provides immediate info. The point I wanted to make is that the text file only contains the "list one" part of the ISO 4217. Looks like "list two" is a subset of list one (as they are funds codes), but "list three", which lists historic codes, is definitely not covered in that file. I am ok with the suggested name, but then we should include some comments mentioning this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19813#issuecomment-2181418086
