On Wed, 26 Jun 2024 17:53:07 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add new line when having multi-line doc comment
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 591:
> 
>> 589:     /**
>> 590:      * @since 23
>> 591:      */
> 
> IIUC, this addition will add & inherit the javadoc from `NumberFormat`, which 
> is not the case before. The description for NumberFormat does not fit with 
> ChoiceFormat. Probably that needs to be addressed with a different issue.

My review is for the ChoiceFormat class only. So asking for more Reviews for 
other area

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18954#discussion_r1655309499

Reply via email to