On Wed, 3 Jul 2024 16:57:49 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Vanitha B P has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8325525 Addressed review comments
>
> test/jdk/tools/jpackage/share/JpackageTest.java line 79:
> 
>> 77:             // parse to get regedit PID
>> 78:             regeditPid = Long.parseLong(pidStr.split("=", 2)[1]);
>> 79:             logger.info("Regedit PID is " + regeditPid);
> 
> We use `TKit.log()` for logging in jpackage tests. You can do 
> `TKit.log("Regedit PID is " + regeditPid)`

log(String) is not public in TKit; cannot be accessed from outside package

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1665819402

Reply via email to