On Wed, 10 Jul 2024 22:02:12 GMT, Shaojin Wen <[email protected]> wrote:
>> The current HexFormat defines an Enum to represent LowerCase and UpperCase
>>
>>
>> class HexFormat {
>> private enum Case {
>> LOWERCASE,
>> UPPERCASE
>> }
>> }
>>
>>
>> This will cause the JVM to load one more class when it starts, which can be
>> seen as follows
>>
>>
>> public class Startup {
>> public static void main(String[] args) {}
>> }
>>
>>
>>
>> java -verbose:class Startup
>>
>>
>>
>> [0.094s][info][class,load] java.util.HexFormat$Case source:
>> /Users/.../jdk/modules/java.base
>>
>>
>> There are only two cases here, which can be represented by boolean, which is
>> clearer and can improve the startup speed a little bit.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> copyright
Thanks for the detailed rationale and explanations! Runs fine on CI.
-------------
Marked as reviewed by liach (Committer).
PR Review: https://git.openjdk.org/jdk/pull/20060#pullrequestreview-2170564329
