On Mon, 15 Jul 2024 19:58:23 GMT, fabioromano1 <d...@openjdk.org> wrote:
>> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The algorithm is proved to be asymptotically faster than the Newton's >> Method, even for small numbers. To get an idea of how much the Newton's >> Method is slow, consult my article >> [here](https://arxiv.org/abs/2406.07751), in which I compare Newton's Method >> with a version of classical square root algorithm that I implemented. After >> implementing Zimmermann's algorithm, it turns out that it is faster than my >> algorithm even for small numbers. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Optimized shift-and-add operations src/java.base/share/classes/java/math/MutableBigInteger.java line 945: > 943: } else { > 944: leftShift(n << 5); > 945: add(addend); This method could be further optimized by implementing the shift and sum together directly here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1678780472
