On Thu, 18 Jul 2024 20:51:48 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Proposing a new overload method for `Process#waitFor()` which takes a >> `Duration` for the timeout value. This will reduce the possibility for >> making mistakes with the `TimeUnit` in the other overload method. A >> corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > removed a blank line src/java.base/share/classes/java/lang/Process.java line 504: > 502: */ > 503: public boolean waitFor(Duration duration) throws > InterruptedException { > 504: Objects.requireNonNull(duration, "duration"); Does this explicit null-check pull its weight here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1683585609