On Mon, 12 Aug 2024 16:21:48 GMT, Chen Liang <[email protected]> wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix comments
>> - remove unused code
>
> src/java.base/share/classes/java/lang/invoke/MemberName.java line 961:
>
>> 959: return null;
>> 960: }
>> 961: if (allowedModes != LM_TRUSTED) {
>
> ❌ You must revert changes to permission checks before a potential
> integration. This can involve security and massively increase the review
> complexity and risk of conformance violation.
Had missed these changes - must've been added as a workaround before we erased
the method types and is probably pointless anyhow now?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20273#discussion_r1714270207
