On Wed, 14 Aug 2024 21:02:47 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use jdk.test.lib.Utils.getRandomInstance() > > src/hotspot/share/runtime/synchronizer.hpp line 126: > >> 124: >> 125: static bool quick_notify(oopDesc* obj, JavaThread* current, bool All); >> 126: > > Why add the extra blank line? The `quick` grouping seemed inconsistent. Was probably thinking about moving down `quick_enter_legacy`. But in the end, there is no obvious grouping. The newline must have slipped through, I'll revert it. Suggestion: ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1718006715