On Mon, 12 Aug 2024 18:36:51 GMT, Severin Gehwolf <[email protected]> wrote:
>> Jan Kratochvil has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Inline adjust_controller() twice
>> - Revert "Unify 4 copies of adjust_controller()"
>>
>> This reverts commit 77a81d07d74c8ae9bf34bfd8df9bcaca451ede9a.
>
> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 120:
>
>> 118: args.add(jdkTool);
>> 119: args.add("-cp");
>> 120: args.add(System.getProperty("java.class.path"));
>
> Should probably be `test.classes` instead of `java.class.path`.
It cannot be as the testcases spawns a new Java process and it cannot replicate
its own commandline from JTREG (I haven't found it in system properties). In
such case `java.class.path` works but `java.classes` is null.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17198#discussion_r1720603883
