On Thu, 25 Jul 2024 22:33:44 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. >> >> The cleanup in `JavaLangReflectAccess` is: >> - Converted `newConstructor` taking parameters to taking another constructor >> and a new accessor. The old existing API essentially does a copy and sets an >> accessor. >> - Removed lots of constructor getters, unused after `newConstructor` cleanup. >> - Removed accessor getter/setters, unused after `newConstructor` cleanup. >> - Removed `leafCopyMethod`. We can already use `getRoot` plus `copyMethod` >> to achieve the same effect. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Remove editor folds, improve comments > - Merge branch 'm5' into cleanup/reflect-access > - 8336934: Clean up JavaLangReflectAccess Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/20290#issuecomment-2300014330
