On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> As a preparation for Hermetic Java, we need to have a way to look up during 
>> runtime if we are using a statically linked library or not.
>> 
>> This change will be the first step needed towards compiling the object files 
>> only once, and then link them into either dynamic or static libraries. (The 
>> only exception will be the linktype.c[pp] files, which needs to be compiled 
>> twice, once for the dynamic libraries and once for the static libraries.) 
>> Getting there will require further work though. 
>> 
>> This is part of the changes that make up the draft PR 
>> https://github.com/openjdk/jdk/pull/19478, which I have broken out.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Also update build to link properly

I compared the extracted changes in this PR with the related parts in 
https://github.com/openjdk/jdk/pull/19478. They look ok. My concern (as 
discussed in https://github.com/openjdk/jdk/pull/19478#issuecomment-2278421931) 
is  that these runtime changes for static JDK can't be tested even they are 
relatively simple, without the the actual linking change. Any timeline for the 
static linking changes?

-------------

PR Review: https://git.openjdk.org/jdk/pull/20666#pullrequestreview-2252486767

Reply via email to