On Thu, 29 Aug 2024 05:05:58 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> since the last revision: >> >> - Fixed copyright dates >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> jep-483-step-01-8338017-add-aot-command-line-aliases >> - Merge branch 'master' into >> jep-483-step-01-8338017-add-aot-command-line-aliases >> - Fixed whitespaces >> - 8338017: Add AOT command-line flag aliases > > src/java.base/share/native/libjli/java.c line 1521: > >> 1519: dumpSharedSpaces = JNI_TRUE; >> 1520: } >> 1521: if (JLI_StrCmp(arg, "-XX:AOTMode=create") == 0) { > > This is inappropriate - the launcher does not, and should not, process > hotspot -XX options. Any aliasing should happen in the hotspot argument > processing logic. I realize this poses a problem with communicating to the launcher that this is a "terminal" flag. Maybe AOT should have -X flags instead of -XX? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1735576562
