On Mon, 2 Sep 2024 09:05:17 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Exclude test on 32-bit > > Deprecating the existing function and introducing the new function looks okay. > > The test is really 3 tests in one (GetStringUTFLength returning a truncated > size, GetStringUTFLength with -Xcheck:jni prints a warning, and > GetStringUTFLengthAsLong returns the long size). Personally I would have done > this as 3 test cases rather in one launch with -Xcheck:jni but that's your > choice. Thanks for the review @AlanBateman . I like the test the way it is. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20784#issuecomment-2324302820
