On Mon, 2 Sep 2024 12:15:10 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> If the aim is to reduce the number of nodes, we could merge the >> Op_SaturatingAddVB, Op_SaturatingAddVS, Op_SaturatingAddVI, and >> Op_SaturatingAddVL into one Op_SaturatingAddV. Likewise for unsigned >> saturating add into Op_SaturatingUnsignedAddV. > > Hey @sviswa7, our concern was around value ranges of new unsigned scalar > type, which as mentioned will be addressed when I support intrinsification of > new core lib APIs and associated range constraining / folding optimization in > a follow up patch. Reiterating, we are not adding unsigned scalar types with this patch, we are only supporting unsigned (saturating) operations on existing signed integral types. So in my thoughts, we could avoid this change as I mentioned above, but I will leave this one to other reviewers. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1742772702
