On Fri, 6 Sep 2024 07:05:22 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> When running jtreg test java/lang/ProcessHandle/PermissionTest.java on >> macOS, a few times this error occurs : >> >> java.lang.RuntimeException: Cannot allocate memory >> at java.base/java.lang.ProcessHandleImpl.getProcessPids0(Native >> Method) >> at >> java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:456) >> at >> java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:434) >> at PermissionTest.childrenWithPermission(PermissionTest.java:84) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) >> at java.base/java.lang.reflect.Method.invoke(Method.java:573) >> at >> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) >> at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599) >> at >> org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174) >> at >> org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46) >> at >> org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822) >> at >> org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147) >> at >> org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146) >> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128) >> at java.base/java.util.ArrayList.forEach(ArrayList.java:1597) >> >> >> Probably sysctl fails here, but it is not fully clear; it would help to >> change the exception so that the standard text is shown too in the exception >> message. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > check for ENOMEM LGTM src/java.base/macosx/native/libjava/ProcessHandleImpl_macosx.c line 115: > 113: // Allocate buffer big enough for all processes; add a little > 114: // bit of space to be able to hold a few more proc infos > 115: // for processes started rigth after the first sysctl call typo: "rigth" ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20839#pullrequestreview-2286516816 PR Review Comment: https://git.openjdk.org/jdk/pull/20839#discussion_r1747278295
