On Fri, 6 Sep 2024 06:40:18 GMT, Jatin Bhateja <[email protected]> wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathUtils.java
>> line 78:
>>
>>> 76: * @since 24
>>> 77: */
>>> 78: public static long addSaturating(long a, long b) {
>>
>> Are these public methods any Java dev could use? If so: do we have tests for
>> them?
>
> Made them package private. These routines are exercised by newly added jtreg
> tests.
These methods need to be public, as the need to be used in any tail
computation. Recommend naming as `VectorMath` aligning with the naming of
`Math` and `StrictMath`.
* The class {@code VectorMath} contains methods for performing
* scalar numeric operations in support of vector numeric operations.
For each method we can reference the associated vector operator.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1747520954
