On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan <s...@openjdk.org> wrote: > Hi all, > This PR delete tedious bool type define in > `src/java.base/unix/native/libjsig/jsig.c` and > `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP > 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we > can "#include <stdbool.h>" to use bool type directly, like > [string.h](https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/native/libpipewire/include/spa/utils/string.h#L13) > do. > Make code more concision, the risk is quite low. > > Additional testing: > > - [x] Local build with --with-hsdis=binutils > --with-binutils=$HOME/software/binutils > - [x] Jtreg tests(include tier1/tier2/tier3 etc.) on linux x64 > - [x] Jtreg tests(include tier1/tier2/tier3 etc.) on linux aarch64
Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20909#issuecomment-2340620724
