On Tue, 10 Sep 2024 21:42:08 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> well I'm not satisfied with the answers :) I removed mswsock.lib from libnio >> dependencies >> [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89) >> and the build still passed. > > And you did not get `mswsock.lib: FileDispatcherImpl.obj : error LNK2019: > unresolved external symbol TransmitFile`? Right. This PR moves FileDispatcherImpl.c to libjava, so FileDispatcherImpl.obj is no longer there. I'm guessing that our makefiles don't detect source files that were removed, and Brian didn't run `make clean`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1753167982
