On Fri, 13 Sep 2024 23:10:19 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org> wrote:
>> Hi Joe (@jddarcy), >> >> As suggested by Sandhya (@sviswa7), I added ~750 fixed point tests for tanh >> in `TanhTests.java` using the quad precision tanh implementation in >> libquadmath library from gcc. >> >> Please let me know if this looks good. > > @vamsi-parasa In my thoughts the best way to do this is add the additional > tests points to HyperbolicTests.java itself in the testcases array of > testTanh() method. We should remove all the other changes from > HyperbolicTests.java. Also no need for separate TanhTests.java file. Hi Sandhya(@sviswa7), please see the updated code in `HyperbolicTests.java` which removes the previous random based tests with the new fixed point tests. Also removed the `TanhTests.java`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20657#discussion_r1761642227
