On Thu, 19 Sep 2024 05:03:50 GMT, Amit Kumar <amitku...@openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove PC save/restore on s390
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3063:
> 
>> 3061:     address start = __ pc();
>> 3062: 
>> 3063:     __ resolve_jobject(Z_ARG1, Z_tmp_1, Z_tmp_2);
> 
> @JornVernee is it possible to rebase to head stream ? If there are no issue 
> on other archs :-) 
> 
> I have implemented `resolve_global_jobject` method for s390x and merged 
> changes to head stream with PR https://github.com/openjdk/jdk/pull/20986. 
> Once rebased you can push below change. 
> 
> Suggestion:
> 
>     __ resolve_global_jobject(Z_ARG1, Z_tmp_1, Z_tmp_2);

I've switched s390 to use `resolve_global_jobject` as well now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20479#discussion_r1766727056

Reply via email to