On Tue, 1 Oct 2024 09:02:36 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Small correction to ensure n > leadingZeros && nBits > leadingZeros > > test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 115: > >> 113: leftShiftAssertions(x, n); >> 114: } >> 115: } > > I think this can be made `@ParameterizedTest` by refactoring `cases` into a > method? > > Otherwise looks good. This doesn't run. You should use JUnit's `Arguments` type and `arguments` method to build the test cases with [multiple parameters](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests-sources-MethodSource), and change the header of the parameterized test to reflect them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1782757196
