On Tue, 1 Oct 2024 14:21:19 GMT, fabioromano1 <[email protected]> wrote:
>> This implementation of MutableBigInteger.leftShift(int) optimizes the
>> current version, avoiding unnecessary copy of the MutableBigInteger's value
>> content and performing the primitive shifting only in the original portion
>> of the value array rather than in the value yet extended with trailing zeros.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Code simplification
test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 69:
> 67: @MethodSource("pathTargetedCases")
> 68: public void test(MutableBigIntegerBox x, int n) {
> 69: leftShiftAssertions(x, n);
One last thing... It would make sense to inline `leftShiftAssertions()` and
remove it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1783090677
