On Tue, 22 Oct 2024 01:46:45 GMT, Alexander Matveev <[email protected]>
wrote:
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing Xcode with command line developer tools.
> - Reason for this is that `codesign` works fine on recent macOS versions and
> it looks like dependency on Xcode with command line developer tools is no
> longer required. Unfortunately it is unknown which macOS versions are require
> Xcode with command line developer tools in order to `codesign` work, so this
> check will be done as soft check.
> - SigningOptionsTest which requires "Xcode with command line developer tools"
> on some older macOS versions was modified to skip certain tests which might
> fail if Xcode is not installed.
Changes requested by asemenyuk (Reviewer).
test/jdk/tools/jpackage/macosx/base/SigningCheck.java line 104:
> 102: } catch (IOException | InterruptedException ex) {
> 103: throw new RuntimeException(ex);
> 104: }
Can be reduced to:
public static void isXcodeDevToolsInstalled() {
if (Executor.of("/usr/bin/xcrun", "--help").execute().getExitCode() != 0) {
TKit.throwSkippedException("Missing Xcode with command line developer
tools");
}
}
Also will add a log record to help evaluate potential test failure.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21628#pullrequestreview-2386121638
PR Review Comment: https://git.openjdk.org/jdk/pull/21628#discussion_r1811280576
