On Wed, 30 Oct 2024 19:06:58 GMT, Coleen Phillimore <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add klass_name check for is_object_wait0
>> - Fix comment in continuation.hpp
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2235:
>
>> 2233: assert(!mon_acquired || mon->has_owner(_thread), "invariant");
>> 2234: if (!mon_acquired) {
>> 2235: // Failed to aquire monitor. Return to enterSpecial to unmount
>> again.
>
> typo: acquire
Fixed.
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2492:
>
>> 2490: void ThawBase::throw_interrupted_exception(JavaThread* current, frame&
>> top) {
>> 2491: ContinuationWrapper::SafepointOp so(current, _cont);
>> 2492: // Since we might safepoint set the anchor so that the stack can we
>> walked.
>
> typo: can be walked
Fixed.
> src/hotspot/share/runtime/javaThread.hpp line 334:
>
>> 332: bool _pending_jvmti_unmount_event; // When
>> preempting we post unmount event at unmount end rather than start
>> 333: bool _on_monitor_waited_event; // Avoid
>> callee arg processing for enterSpecial when posting waited event
>> 334: ObjectMonitor* _contended_entered_monitor; // Monitor por
>> pending monitor_contended_entered callback
>
> typo: Monitor **for** pending_contended_entered callback
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823583906
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823583954
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823583822
