On Wed, 20 Nov 2024 03:16:47 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 344:
>
>> 342: private List<String> prefixCommandLineArgs() {
>> 343: if (winEnglishOutput) {
>> 344: return List.of("cmd.exe", "/c", "chcp", "437", ">nul",
>> "2>&1", "&&");
>
> I assume `chcp 437` works as expected. The summary still references `chcp
> 65001` command.
Yes, I confirmed that it works as expected.
> The summary still references chcp 65001 command.
Thanks, I fixed summary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1849501309
