On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs <[email protected]> wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
The changes to SystemLogger looks OK to me. Maybe you could get rid of the
LoggerFinder `private static Void checkPermission()` method altogether?
And also of the associated private constructor `LoggerFinder(Void)` as well as
the
static final RuntimePermission LOGGERFINDER_PERMISSION =
new RuntimePermission("loggerFinder");
constant (which should no longer be needed now?)
Note: I am taking care of the System.Logger default implementation classes in
https://github.com/openjdk/jdk/pull/22281.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22282#pullrequestreview-2449564572
PR Review: https://git.openjdk.org/jdk/pull/22282#pullrequestreview-2449568644
PR Comment: https://git.openjdk.org/jdk/pull/22282#issuecomment-2489432747
