On Mon, 25 Nov 2024 07:26:56 GMT, Per Minborg <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix failing tests
>
> src/java.base/share/classes/jdk/internal/foreign/NativeMemorySegmentImpl.java
> line 39:
>
>> 37: * a native long address.
>> 38: */
>> 39: public sealed class NativeMemorySegmentImpl extends
>> AbstractMemorySegmentImpl permits MappedMemorySegmentImpl {
>
> Why does this class have to be `public`? Maybe it was a change that survived
> from the larger version of the PR? The same goes for
> `MappedMemorySegmentImpl`.
Because it is returned from the public methods in `SegmentFactories`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22344#discussion_r1856363625
