On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupSubsystemController.java
>> - leave out MethodUtil from the clean up
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
> line 167:
>
>> 165: if (controller == null) return defaultRetval;
>> 166:
>> 167: try (Stream<String> lines =
>> Files.lines(Paths.get(controller.path(), param))) {
>
> Using Path.of might be clearer here.
What Alan said.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22478#discussion_r1865861779
