On Mon, 2 Dec 2024 14:24:25 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve docs
>
> test/jdk/java/foreign/TestStringEncoding.java line 263:
>
>> 261: for (var arena: arenas()) {
>> 262: try (arena) {
>> 263: MemorySegment strSegment =
>> arena.allocateFrom(testString, charset);
>
> This could just use String::getBytes ? E.g. you don't really need the
> `strSegment`
True. But then again, I do not need the byte array either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22451#discussion_r1866105678
