On Mon, 9 Dec 2024 17:43:45 GMT, Severin Gehwolf <[email protected]> wrote:
>>> If we change how jpackage defines ALL-DEFAULT we could reduce it
>>
>> I agree. jpackage can define ` ALL-DEFAULT` using public API, no need to use
>> internal API.
>
> @alexeysemenyukoracle Do you mean it would be OK to re-define `ALL-DEFAULT`
> to not include `jdk.jlink` for runtime images? Would that be OK in general
> for `jpackage`?
I meant the use of `jdk.internal.module.ModulePath` can be replaced with public
API in `JLinkBundlerHelper.java`. Sorry for the confusion.
Can test if jlink tool is available as an alternative to importing
`jdk.tools.jlink.internal.LinkableRuntimeImage` from jpackage:
private static final boolean LINKABLE_RUNTIME =
ToolProvider.findFirst("jlink").isPresent();
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22644#discussion_r1876466361
