On Wed, 18 Dec 2024 02:16:55 GMT, Valerie Peng <[email protected]> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8340493
>> - rename to expected, unexpected, and actual
>> - the fix
>
> test/lib/jdk/test/lib/Asserts.java line 244:
>
>> 242: * @see #assertEqualsByteArray(byte[], byte[], String)
>> 243: */
>> 244: public static void assertEqualsByteArray(byte[] expected, byte[]
>> actual) {
>
> Based on
> [ML_KEM_Test.java](https://java.se.oracle.com/source/xref/jdk-jdk/jdk-open/test/jdk/sun/security/provider/acvp/ML_KEM_Test.java)
> and
> [ML_DSA_Test.java](https://java.se.oracle.com/source/xref/jdk-jdk/jdk-open/test/jdk/sun/security/provider/acvp/ML_DSA_Test.java),
> it looks like the first argument should be actual and the 2nd argument is
> expected.
Also, it's not about "the same byte array", but more like "the same bytes" or
have equal values, right?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21101#discussion_r1889525000
