On Fri, 13 Dec 2024 23:29:23 GMT, Henry Jen <[email protected]> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 584:
>>
>>> 582: private void dedups(ModuleDescriptor md) {
>>> 583: // exports
>>> 584: for (Exports e : sorted(md.exports())) {
>>
>> Is sorting needed? de-duplicating shouldn't depend on the order of the
>> input, should it?
>
> I will need to check again, this was added when we need to ensure the
> sequence of cache from the dedupSet to reproduce same image.
Delay the sorting to the DedupSet build time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1895211270
