On Wed, 8 Jan 2025 23:29:22 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Don't remove the `PATH` variable from the environment when running app 
>> launchers in jpackage tests;
>> - Fix tests that use `Executor` rather than `HelloApp` class to run app 
>> launchers: apply the same changes to the environment as would be applied by 
>> `HelloApp` class.
>> - Replace `Executor.setRemovePathEnvVar()` with `Executor.removeEnvVar()` to 
>> support removal of any variable from the environment of a child process 
>> executed in jpackage tests;
>> - Add support of a new boolean property 
>> `jpackage.test.clear-app-launcher-java-env-vars` in jpackage tests. If it is 
>> set to "true", the `JAVA_TOOL_OPTIONS` and `_JAVA_OPTIONS` variables will be 
>> removed from the environment of app launchers executed in jpackage tests. It 
>> is handy in local testing using jpackage test runner instead of the jtreg.
>> 
>> The first and the second changes are unrelated to other changes. They are 
>> bundled together as they apply to the same source code.
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix copyright year

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22983#pullrequestreview-2538523767

Reply via email to