On Mon, 13 Jan 2025 21:38:04 GMT, Justin Lu <[email protected]> wrote:
> Please review this PR which removes a leftover `doPrivileged` call in the
> Currency test, _CheckDataVersion.java_.
test/jdk/java/util/Currency/CheckDataVersion.java line 79:
> 77: } catch (IOException ioe) {
> 78: throw new RuntimeException(
> 79: "CheckDataVersion was not set up properly: " +
> ioe);
IOException could happen not by the test setup failure, but for the case the
`currency.data` file in the JDK is missing or corrupt, so if you want to give
extra message to the exception, needs some rewording. Also, I prefer `ioe`
should be the `cause` and not to be consumed in the message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23087#discussion_r1913898713
