On Sat, 26 Oct 2024 17:09:29 GMT, Markus KARG <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/CharSequence.java line 338:
>>
>>> 336: * @since 24
>>> 337: */
>>> 338: public default void getChars(int srcBegin, int srcEnd, char[] dst,
>>> int dstBegin) {
>>
>> Shouldn't the `getChars` methods of `String`, `AbstractStringBuilder`,
>> `StringBuilder` and `StringBuffer` be marked with `@Override`?
>
> While technically not being necessary, it is definitively a good idea. I will
> add it to the draft once we actually agreed that we really want to go with
> this particular signature (see the discussion with Chen).
Fixed in `String` and `AbstractStringBuilder`. There is no
`StringBuilder.getChars`. `StringBuffer.getChars` already has `@Override`, just
as `CharBuffer.getChars`. Thanks for the tip! 👍
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r1947929157
