On Mon, 24 Feb 2025 19:18:27 GMT, Alexey Semenyuk <[email protected]> wrote:
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory()` call.
> - AppImagePackageTest.java: replace `TKit.createTempDirectory(null)` with
> `TKit.createTempDirectory("appimage")` to fix NPE.
> - Make `TKit.assertDirectoryExists(Path, Optional<Boolean>)` private. This
> is internal and shouldn't be exposed.
> - add `TKit.assertEquals(boolean, boolean)` and
> `TKit.assertNotEquals(boolean, boolean)` with tests.
> - AdditionalLauncher.java: remove redundant code duplicating functionality
> of `TKit.createTempFile()` (should have been cleaned long ago).
> - JPackageCommand.java: add a check for the main jar in the app image if the
> main jar was specified. Missing part of
> [JDK-8325089](https://bugs.openjdk.org/browse/JDK-8325089).
@sashamatveev PTAL
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23754#issuecomment-2679446041
