On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) <[email protected]> wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>> Helpful messages.
>
> He-Pin(kerr) has updated the pull request incrementally with one additional
> commit since the last revision:
>
> chore: update tests
src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java line
1513:
> 1511: } else if (corePoolSize > maximumPoolSize) {
> 1512: throw new IllegalArgumentException("corePoolSize must be
> less than or equal to maximumPoolSize, " +
> 1513: "but got maximumPoolSize:" + maximumPoolSize + "
> corePoolSize :" + corePoolSize);
Suggestion:
"but got maximumPoolSize: " + maximumPoolSize + ", and
corePoolSize : " + corePoolSize);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23050#discussion_r1971607329
