Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v10]

[Daniel Fuchs]

On Fri, 28 Feb 2025 14:23:49 GMT, David Beaumont <d...@openjdk.org> wrote:

>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized 
>> publish() method.
>> 
>> 1. Remove synchronization of calls to publish() in Handlers in 
>> java.util.logging package.
>> 2. Add explanatory comments to various affected methods.
>> 3. Add a test to ensure deadlocks no longer occur.
>> 
>> Note that this change does not address issue in MemoryHandler (see 
>> JDK-8349208).
>
> David Beaumont has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Final round of comment tweaks.

src/java.logging/share/classes/java/util/logging/FileHandler.java line 747:

> 745: 
> 746:     @Override
> 747:     void synchronousPostWriteHook() {

Suggestion:

    void synchronousPostWriteHook() {
        // no need to synchronize here, this method is called from within a
        // synchronized block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23491#discussion_r1975777682