On Thu, 10 Apr 2025 14:42:26 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Alexey Semenyuk has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new commit since the last revision:
>>
>> Update tests and implementation to comply with the CSR (env var names are
>> case-insesitive on Windows)
>
> src/jdk.jpackage/share/man/jpackage.md line 228:
>
>> 226: An expandable substring should be enclosed between the dollar
>> 227: sign character ($) and the first following non-alphanumeric
>> 228: character. Alternatively, it can be enclosed between "${" and "}"
>
> This did not sit well with pandoc, that reports:
>
> [WARNING] Could not convert TeX math ) and the first following
> non-alphanumeric character. Alternatively, it can be enclosed between ",
> rendering as TeX:
> e enclosed between "
> ^
> unexpected '"'
> expecting "\\bangle", "\\brace", "\\brack", "\\choose", "\\displaystyle",
> "\\textstyle", "\\scriptstyle", "\\scriptscriptstyle", "{", "\\operatorname",
> letter, digit, ".", "!", "'", "''", "'''", "''''", "*", "+", ",", "-", ".",
> "/", ":", ":=", ";", "<", "=", ">", "?", "@", "~", "_", "^", "\\left", "\",
> "\\hyperref" or end of input
I'm guessing a possible fix would be to use
`${`
or
"`${`"
instead.
Alternatively, we need to tell pandoc to not try and use any encoded TeX math
in markdown files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23923#discussion_r2037596802
