On Thu, 10 Apr 2025 14:48:59 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' into jnativescan_Refactor
>> - bump copyright years
>> - merge ClassResolver and SystemClassResolver
>> - Simplify ClassResolver
>
> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/NativeMethodFinder.java
> line 97:
>
>> 95: }
>> 96: Optional<ClassModel> modelOpt =
>> systemClassResolver.lookup(methodRef.owner());
>> 97: if (!modelOpt.isPresent()) {
>
> Maybe add a comment here saying that restricted methods must be in system
> classes?
I've added a comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24493#discussion_r2037892007