On Mon, 2 Jun 2025 21:48:04 GMT, Naoto Sato <[email protected]> wrote:
> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
> `CharsetTest` was a clean-up and not the gist of the original issue, the
> change seem to have caused not finding `SkippedException` at runtime in
> certain cases. Changing the test to JUnit based so that the offending
> `SkippedException` can be replaced with JUnit's `Assumptions`. Also renamed
> the test case itself to reflect what's actually tested in it.
test/jdk/java/io/Console/StdoutEncodingTest.java line 72:
> 70: if (eval != 0) {
> 71: throw new RuntimeException("Test failed. Exit value from
> 'expect' command: " + eval);
> 72: }
suggestion: `assertEquals(0, eval, "exit value");`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25601#discussion_r2122817415
