On Wed, 4 Jun 2025 09:35:25 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Daniel's suggestion - consistent use of {@code "readOnly"}
>
> src/jdk.zipfs/share/classes/module-info.java line 195:
>
>> 193: * If the value is {@code true}, the ZIP file system provider
>> creates a
>> 194: * new ZIP or JAR file if it does not exist. Specifying the
>> {@code create}
>> 195: * property as {@code true} with the {@code accessMode} as {@code
>> readOnly}
>
> should we change that to `with <em>read-only</em> {@code accessMode}` or to
> `with the {@code accessMode} as {@code "readOnly"}`?
I see your reasoning. In the `accessMode` property description, we have used
`{@code "readOnly"}`. I will go ahead and change it to `with the {@code
accessMode} as {@code "readOnly"}`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25634#discussion_r2126822336
