On Sat, 7 Jun 2025 17:36:40 GMT, Johannes Graham <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review - Moving all ISO resources to LocaleISOData & blessed modifier
>> order for languageTag
>
> src/java.base/share/classes/java/util/Locale.java line 1282:
>
>> 1280: public static Set<String> getISOCountries(IsoCountryCode type) {
>> 1281: Objects.requireNonNull(type);
>> 1282: return switch (type) {
>
> The body of this method could also be moved to a method in `LocaleISOData`
I think it's OK as is, don't want to force re-approvals. Currently it is
consistent with the other ISO related methods in `Locale`, which grab the ISO
resources from `LocaleISOData` but handle some logic on their own as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25646#discussion_r2136488492
