On Wed, 11 Jun 2025 05:23:12 GMT, Emanuel Peter <[email protected]> wrote:
>> erifan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Support negating unsigned comparison for BoolTest::mask
>>
>> Added a static method `negate_mask(mask btm)` into BoolTest class to
>> negate both signed and unsigned comparison.
>
> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 158:
>
>> 156: } else if (op == VectorOperators.UGT) {
>> 157: Asserts.assertEquals(compareUnsigned(a, b) <= 0, r);
>> 158: }
>
> Please refactor it as a `switch`. And add a `default` case where you throw
> some `RuntimeException`. just to make sure we are not missing anything :)
`VectorOperators.XXX` is not compile time constants, we can't use `switch` here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2139418759
