On Mon, 23 Jun 2025 19:54:24 GMT, Roger Riggs <[email protected]> wrote:
>> @RogerRiggs My preferred formatting style is like this:
>>
>>
>> default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>> ShardingKey superShardingKey,
>> int timeout) throws SQLException {
>>
>>
>> But as you said, there is previous reformattings that does not follow it. If
>> you agree, I will fix them. What do you thing about it?
>>
>> About the issue title and PR title, we can make it more general like:
>>
>> "Improve Readability and Maintainability of Connection.java"
>>
>> What your suggestion on it?
>
> I would backout the changes to signatures, fixing the bad indentation and
> leave it at that.
> Lance is one of the long time maintainers of the SQL classes and will want to
> take a look.
Great! I will do that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2162442176
