On Fri, 27 Jun 2025 16:23:59 GMT, Jaikiran Pai <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc cleanup
>
> src/java.base/share/classes/java/lang/ProcessBuilder.java line 545:
>
>> 543: * {@snippet lang = "java" :
>> 544: * Redirect.DISCARD.file() // is the filename appropriate
>> for the operating system
>> 545: * Redirect.DISCARD.type() == Redirect.Type.WRITE
>
> With this use of snippet here I think it no longer conveys what the original
> `{@code}` block was trying to convey. I can't currently think of a better
> proposal either.
Updated `Redirect.DISCARD.file() != null &&` // so its a valid expression.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25884#discussion_r2180227712
