On Fri, 11 Jul 2025 03:45:14 GMT, Xiaohong Gong <xg...@openjdk.org> wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding masked associative tests
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
> line 580:
>
>> 578: * @see VectorMath#addSaturatingUnsigned(int, int)
>> 579: */
>> 580: public static final Associative SUADD = assoc("SUADD", "+",
>> VectorSupport.VECTOR_OP_SUADD, VO_NOFP+VO_ASSOC);
>
> Suggestion:
>
> public static final Associative SUADD = assoc("SUADD", "+",
> VectorSupport.VECTOR_OP_SUADD, VO_NOFP + VO_ASSOC);
Ordinarily I'd agree, but I'm going to keep with the established pattern in
this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26099#discussion_r2201155129
