On Mon, 14 Jul 2025 18:10:53 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Looks good. Thanks for adding case folding support which is long overdue 🙂 > Since this is adding a new support for casefolding for character class > ranges, I think CSR and a release note should be considered. Thanks for the review. Arguably, the change I made years ago to support Level 1 + RL2.1/2 already implies that character class ranges should conform to RL1.5 — just like other constructs (back-ref, slice, single and property) So it might be reasonable to categorize this as "just" a pure bug fix. That said, it is a behavioral change, and I’m happy to go through the CSR and release note process if strongly preferred. 🙂 My initial thought was to defer the CSR until we fully switch to a case-folding-mapping–based implementation (replacing the current toUpperCase/toLowerCase logic), at which point we could also update the javadoc to explicitly document the behavior of each construct, as RL1.5 recommends/suggests. But if we prefer to align all of that now with this fix, I’m fine doing it together. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26285#issuecomment-3070905666
