On Thu, 10 Jul 2025 00:27:55 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/RuntimeBundle-Info.plist.template >> line 6: >> >>> 4: <dict> >>> 5: <key>CFBundleDevelopmentRegion</key> >>> 6: <string>English</string> >> >> I'm surprised there is no standard way to override this default value. Is it >> not important? > > https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledevelopmentregion?language=objc > > By default it will be `en-US`. Not sure why JDK Info.plist has `English`, > since it is not a documented value. Also all jpackage Info plist template > files also have `English`. I think we need to file a separate bug and change > it to `en-US` or remove it. I think remove it is better, since no need to set > it to default value. > > Not sure if it is important for `runtime bundles`, but for `application > bundles` it might be important in case if application does not have English > localization. For example application is only in German language, then this > value should be set to German language ID. I think it might make sense to > file a bug to investigate if we want to provide CLI option to specify value > for `CFBundleDevelopmentRegion` similar to `--mac-app-category`. Any > suggestions? Please file a bug to address the hardcoded value of the `CFBundleDevelopmentRegion`. We may decide later what to do with it: change it to `en-US`, remove it, or add a new cli option to set it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2205970959
