On Tue, 15 Jul 2025 10:22:08 GMT, David Beaumont <d...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 182:
>>
>>> 180:
>>> 181: private static final class SharedImageReader extends
>>> BasicImageReader {
>>> 182: // TODO: Should this be OPEN_FILES or openFiles (it's not
>>> constant).
>>
>> All caps is good for final statics.
>
> Even if mutable? I've seen both in the codebase so wasn't sure what the style
> should be. I'll remove the TODO.
The Map is mutable but the static field is constant after initialization.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2208450981
